ci: point the docs deploy workflow at develop (#408) - #410
Merged
Conversation
GitHub Actions resolves workflows for non-`push` events from the default branch only, so the `release: published` trigger runs whatever version of this file is on `main`. Without this commit that trigger would keep checking out the orphan `docs` branch after #409 lands, and a release would republish the old tree over the new one. This carries the same file that #409 puts on `develop`. It changes no behaviour on `main` itself: the `push` trigger only matches `develop`, so pushing to `main` still matches nothing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #409, which makes
developthe single source for the published documentation site.Why this needs to target
maindirectlyGitHub Actions resolves workflow files for non-
pushevents from the default branch only. Therelease: publishedtrigger indeploy-docs.ymltherefore runs whatever version of that file is onmain, regardless of whatdevelopsays.maincurrently holds the version that checks out the orphandocsbranch. If #409 merged on its own, the next published release would fire that stale copy and republish the olddocstree over the new site. This closes that window.What it changes on
mainNothing behavioural. The
pushtrigger in this file only matchesdevelop, so pushing tomainstill matches no trigger here. The file is identical to the one #409 puts ondevelop.Merge order
Either order works, but merging this one first is safer: it means there is no point in time where
maincan undo #409.Refs #408