Skip to content

My First Open Source Contribution - #63

Open
FredzioFred wants to merge 1 commit into
Ayushmore1214:mainfrom
FredzioFred:intro/FredzioFred
Open

My First Open Source Contribution#63
FredzioFred wants to merge 1 commit into
Ayushmore1214:mainfrom
FredzioFred:intro/FredzioFred

Conversation

@FredzioFred

Copy link
Copy Markdown

What does this PR do?

I added my name to CONTRIBUTORS.md.

Related Issue

Fixes #

Type of change

  • Intro PR (adding my name to CONTRIBUTORS.md)

How to test this

  1. Clone this branch
  2. Open CONTRIBUTORS.md in a text editor

Screenshots (if applicable)

Checklist

  • I've read CONTRIBUTING.md and followed the steps
  • My commits include Signed-off-by in the message (DCO sign-off)
  • I've tested this change in a browser
  • My changes don't break other parts of the page
  • The PR title is descriptive and follows the project conventions

Signed-off-by: FredzioFred <franciszekchrapek@gmail.com>
@Ayushmore1214

Copy link
Copy Markdown
Owner

Thanks for the intro PR @FredzioFred. Two things to fix before this can go in:

1. The markdown link syntax has a space in it, which breaks the link. Markdown needs [text](url) with no space between the bracket and the paren. Your row also needs a closing |.

Current:

| Franciszek Chrapek | [@FredzioFred] (https://github.com/FredzioFred) | [LinkedIn] (-)

Should be:

| Franciszek Chrapek | [@FredzioFred](https://github.com/FredzioFred) | |

(leave the last cell empty if you'd rather not share a LinkedIn, or put a real [LinkedIn](url) there)

2. The branch now conflicts with main since another intro PR was merged. Sync your fork and rebase:

git remote add upstream https://github.com/Ayushmore1214/FirstCommit.git   # if you haven't already
git fetch upstream
git rebase upstream/main
# fix the conflict in CONTRIBUTORS.md by keeping both rows
git push --force-with-lease

Ping me once it's updated and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants