fix: clear legacy cache variants for one URL - #1105
Draft
Atroci wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1086
Why
The admin-bar Delete Cache action clears the page's supercache directory but leaves legacy wp-cache files for the same URL. Query-string requests expose the gap because they are served by those legacy files, so a URL such as
/some-post/?utm_source=testremains stale after deletion.What Changed
$blog_cache_dirmetadata and delete cache pairs whose URI has the same path, regardless of query string..php/JSON pairs and pre-2015.html/serialized.metapairs.Verification
gclid,fbclid, functional-query, gzip-key, and historical HTML variants for one path.Release Notes
Fixed the Delete Cache action so it clears legacy wp-cache representations for the selected URL, including query-string variants, without recursively clearing child URLs.