Premium Analytics: remove the date range step arrows - #52108
Conversation
The arrows are gone from the date filters row, alongside the mechanism behind them: the surface that still rendered them was the dashboard, and the detail pages already opted out. UNI-751
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SwEiwvYnpNdaqsK71QznVw
Code Coverage SummaryCoverage changed in 3 files.
|
Drops `completeToDateRange` from the datetime barrel, whose only caller outside the package was the step callback, and clears the docs and comments the removal left pointing at things that no longer exist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THgGUBmikHUTBQQ4B2ktSW
Nikschavan
left a comment
There was a problem hiding this comment.
Thank you, the changes look good.
dognose24
left a comment
There was a problem hiding this comment.
LGTM 👍
Clean removal: no reference to any of the removed symbols survives under projects/ at the PR head, no unused imports or dead code left behind (exactRange is still used by drill-down, appliedRange by the comparison source range), and the three sub-packages are private workspace packages so trimming their barrels breaks nothing outside. Nice touch removing the stale "probe" comments in DateFiltersPanel while at it.
One optional wording nit on the changelog entries, non-blocking: "stepped the date range back and forward a period" reads a little awkwardly. "Remove the arrows that stepped the date range back or forward by one period." might read better.
Fixes UNI-751
Proposed changes
DatePeriodNavigation, theonStepprop and callback, andstepDateRange/canStepForward.clampRangeEndToTodayas well, whose only caller was the forward step.onStep: undefinedoverride the detail pages carried, now that there is nothing to switch off.completeToDateRangefrom thedatetimebarrel, its only caller outside the package having been the step callback.Removing rather than hiding: the detail pages already opted out, so the dashboard was the last surface rendering the arrows, and nothing else called the stepping helpers. The date picker, the comparison dropdown and the chart interval control are untouched. This supersedes WOOA7S-1812 (#51118), which added the arrows last month: the date selection was re-specced in the 26 August design recap, and the arrows are not part of that design.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Last 30 days/vs/Previous 30 days/ the chart interval button, with no arrows on either side.Packages/Premium Analytics/UI/DateFiltersPanelcovers the same row, including theDisabledstory.