feat: pin @attomus/semafore-crypto@^1.0.0 and wire final notify/execute paths - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@attomus/semafore-cryptoas a runtime dependency using the requested^1.0.0range; lockfile resolves registry package1.0.1.initSenderSession/encryptMessageenvelope generation, and ADR-0166notify/sendrequest posting.Authorization: Bearer ...and cover all three v1 routes.dist/with crypto code inlined.Contract note
The Action now calls
/api/integrations/notify/recipientsto resolve target recipients and key bundles before posting/api/integrations/notify/send.sf-server/maincurrently exposesnotify/sendbut does not yet expose that service-token recipient/key-bundle resolution route; mobile recipient discovery/key-bundle lookup exists but is JWT-scoped. This PR wires the Action side to the narrow integration route it needs and records the server-side follow-up for Architect.Validation
npm installcompleted with no peer-dependency warnings.npm ls @attomus/semafore-crypto->@attomus/semafore-crypto@1.0.1fromhttps://registry.npmjs.org/@attomus/semafore-crypto/-/semafore-crypto-1.0.1.tgz.npm run verifypassed: lint, type-check, 4 test files / 10 tests, build, audit.gitleaks detect --no-banner -v --redact --report-format json --report-path /tmp/semafore-action-gitleaks-crypto.json-> 0 findings.Bundle size
dist/index.js1,071,809 bytes.dist/index.js1,430,892 bytes.