Harden failed-IP cooldown config and add DEFAULT-mode test#2253
Merged
Conversation
hyperxpro
force-pushed
the
cooldown-fixes
branch
from
July 18, 2026 20:47
88a1a38 to
9dcc3cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
#2221 extended failed-IP cooldown support to all
LoadBalancemodes and made it configurable, but left three gaps. The end-to-end feedback loop inDEFAULTmode, frommarkFailedto IP reordering, was never exercised through the client, leaving regressions undetected. The configuration also accepted negative cooldown periods, silently disabling the feature, and enabling the cooldown with anullperiod in a custom config could causeNettyRequestSenderconstruction to fail with an NPE.Modification:
Add an end-to-end test that verifies
DEFAULTmode deprioritizes a failed IP on subsequent connections using a multi-IP host and fresh connections. Reject negative cooldown periods withIllegalArgumentExceptionwhile continuing to allownull(reset to the default) andDuration.ZERO. GuardNettyRequestSenderagainst anullcooldown period when the feature is enabled, leaving the cooldown disabled instead of failing client construction.Result:
The failed-IP cooldown behavior in
DEFAULTmode is now covered end-to-end, ensuring regressions are detected. Invalid negative configuration now fails fast, and inconsistent custom configurations no longer cause client construction to fail.