fix: restrict privileged desktop IPC - #6
Open
NeerajCodz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
apps/desktop/src/main/security/ipc-security.tswithassertTrustedSenderto validateIpcMainInvokeEventorigins andresolveWorkspacePathto canonicalize and enforce workspace path allowlisting.apps/desktop/src/main/index.tsby passinglaunchCwdtoregisterFileIpcandregisterTerminalIpc.apps/desktop/src/main/ipc/file.ipc.tsto callassertTrustedSenderand resolve all paths throughresolveWorkspacePathbefore read/write/create/rename/delete/copy/move/stat/watch/open/reveal/open-terminal operations.apps/desktop/src/main/terminal/registerTerminalIpc.tsto callassertTrustedSender, validatecwdviaresolveWorkspacePath, and preserve existing terminal request validations.apps/desktop/src/main/security/ipc-security.test.tsthat exerciseresolveWorkspacePathallow/deny rules (including symlink escapes) and basicassertTrustedSenderbehavior.Testing
apps/desktop/src/main/security/ipc-security.test.tsbut running them in this environment failed because dependencies are not installed andvitestwas not found (attemptedbun --filter @orphix/desktop test -- src/main/security/ipc-security.test.ts).git diff --checkwhich reported no whitespace/format errors and committed the changes asfix: restrict privileged desktop IPC.Codex Task