Mobile: add per-login state and strict auth callback validation - #5
Open
NeerajCodz wants to merge 1 commit into
Open
Mobile: add per-login state and strict auth callback validation#5NeerajCodz wants to merge 1 commit into
NeerajCodz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AUTH_STATE_BYTESandcreateAuthState()to generate a cryptographically-random per-loginstatevalue.validateCallbackUrl(callbackUrl, expectedState)that validates scheme, host, path, and thestateparameter before returning tokens.stateand to only persist tokens toSecureStoreaftervalidateCallbackUrlsucceeds.apps/mobile/app/login.tsxand preserve existing token persistence and routing behaviour after validation.Testing
validateCallbackUrland verified valid callbacks are accepted and mismatched-state or wrong-callback-host cases are rejected (success).git diff --checkto ensure no whitespace/patch issues (success).tscfor the mobile project (bunx tsc -p apps/mobile/tsconfig.json --noEmit) which failed due to missing Expo/mobile dev dependencies andexpo/tsconfig.basein this environment (environment limitation, not a code regression).Codex Task