fix: enforce link relay input permissions - #4
Open
NeerajCodz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
view_onlyorapprove_only) to send terminal input, bypassing the intended access-mode approval shown to desktop users.modeor reliably verify thesession_id/terminal mapping before writing to the PTY, creating an authorization bypass.Description
approvedbefore registering the client by checkingsession.statusinapis/link/src/relay.tsduringrelay.authprocessing.modeon the relayClientand reject mobilerelay.messageframes withdirection === "input"unlessclient.mode === "full_control"inapis/link/src/relay.ts.LinkManager::session_allows_terminal_inputincrates/orphix-core/src/link/mod.rsto verify the inboundsession_idmatches the stored desktop session, the storedmodeisfull_control, and the relay mapping points the session to the terminal before accepting input.LinkMessage::RelayMessagebranch to deny unauthorized input before any RPC handling orTerminalManager::writeoccurs.Testing
cargo check -p orphix-corewhich completed successfully.bunx prettier --check apis/link/src/relay.tswhich passed formatting checks after applying changes.bun --filter @orphix/link-api buildbut the TypeScript build failed in this environment due to missing/resolvable dev/peer dependencies and type packages (e.g.fastify,ws,jose,@types/node,@orphix/encryption), so a full API build could not be completed here.Codex Task