fix: reject expired link sessions - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
getLinkSession()could return DB rows whoseexpiresAtis in the past, allowing stale approved sessions to restart relays or authenticate relay sockets.Description
isExpired()helper and enforce expiry inconvex/linkSessions.tsso thegetquery returnsnullfor expired sessions andupdateStatus/updateTransportmutations reject expired sessions.apis/link/src/relay.tsto reject sessions whosestatusis not"approved"before registering participants.convex/linkSessions.test.tsasserting that expired (previously approved) sessions are not returned by thegetquery.Testing
convex/linkSessions.test.ts::does not return expired sessionsbut runningbunx vitest run convex/linkSessions.test.tsin this environment failed due to dependency resolution against the npm registry (HTTP 403), so the test could not be executed here.Codex Task