fix: scope memory upserts by tenant and user - #17
Open
NeerajCodz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
idcould replace another user's record by ensuring upserts are scoped to the tenant/user partition.idcollisions occur.Description
TestMemoryStore::upsert_memoryto match existing records bytenant_id,user_id, andidinstead ofidonly to preserve per-tenant/user isolation.WHEREclause to theON CONFLICT (id) DO UPDATEstatement in the Postgres adapter so updates apply only when the existing row matchestenant_idanduser_id, and return aConflictif no rows were affected.local_store_upsert_scopes_caller_supplied_ids_to_tenant_and_userthat ingests two records with the same caller-suppliedidunder different users and verifies both records remain isolated.Testing
cargo test local_store_upsert_scopes_caller_supplied_ids_to_tenant_and_user, which passed.cargo test, and all tests passed.git diff --checkto validate no whitespace/errors introduced, which reported no issues.Codex Task