fix(streaming): stop close() hanging when no Termination frame arrives - #169
Merged
Conversation
`close()` awaited a promise that only the `Termination` frame resolved, with no timeout. A socket that died after the client sent Terminate left `close()` awaiting forever. - `onclose` now releases the waiter; a dead socket sends no more frames. - `close()` bounds the wait at 5000ms, via a new optional `terminationTimeout`. - `RealtimeTranscriber` had the same bug and gets the same fix. The existing `close()` test helper always sends a Termination frame, so this path had no coverage. The two new hang tests fail on the parent commit.
ccampbell-aai
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close()awaited a promise that only theTerminationframe resolved, with no timeout. A socket that died after the client sent Terminate leftclose()awaiting forever.onclosenow releases the waiter; a dead socket sends no more frames.close()bounds the wait at 5000ms, via a new optionalterminationTimeout.RealtimeTranscriberhad the same bug and gets the same fix.The existing
close()test helper always sends a Termination frame, so this path had no coverage. The two new hang tests fail on the parent commit.