Skip to content

[perf] Pack serially in YuanrongStorageClient (DS_MAX_WORKERS 16 -> 1) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0oshowero0 merged 1 commit into from
Aug 12, 2026
Merged

[perf] Pack serially in YuanrongStorageClient (DS_MAX_WORKERS 16 -> 1) #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion transfer_queue/storage/clients/yuanrong_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ class GeneralKVClientAdapter(StorageStrategy):

PUT_KEYS_LIMIT: int = 10_000
GET_CLEAR_KEYS_LIMIT: int = 10_000
DS_MAX_WORKERS: int = 16
DS_MAX_WORKERS: int = 1

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve parallel packing for large CPU values

When Yuanrong stores general CPU-side values whose packed buffers are large, such as image-sized CPU tensors/ndarrays sent through kv_batch_put, forcing the default to one worker disables the existing parallel pack_into path for every batch. These values are accepted by the public KV/general-object path, and the commit's own size sweep shows serial packing becomes slower past roughly 256 KiB per object (about 1.5x slower at 512 KiB), so an adaptive threshold or configurable default would keep the small-object win without regressing supported large-value workloads.

AGENTS.md reference: AGENTS.md:L17-L18

Useful? React with 👍 / 👎.


def __init__(self, config: dict):
port = config.get("worker_port")
Expand Down
Loading