Skip to content

Add draft copy button - #33

Open
FSS3096 wants to merge 1 commit into
Arthakram:mainfrom
FSS3096:codex/Copytoclipboard
Open

Add draft copy button#33
FSS3096 wants to merge 1 commit into
Arthakram:mainfrom
FSS3096:codex/Copytoclipboard

Conversation

@FSS3096

@FSS3096 FSS3096 commented Jul 16, 2026

Copy link
Copy Markdown

Summary

Type of Change

  • 🐛 Bug fix

  • - [ ] ✨ New feature

  • - [ ] 🔨 Refactor / tech debt

  • - [ ] 📝 Documentation update

  • - [ ] 🚀 Performance improvement

  • - [ ] 🔧 Config / tooling change

  • ## What Changed

  • -

  • -

  • ## Testing

  • - [ ] Manual testing done

  • - [ ] Existing tests pass

  • - [ ] New tests added (if applicable)

  • ## Screenshots / Demo

  • ## Checklist

  • - [ ] Self-reviewed the code

  • - [ ] No console errors or warnings

  • - [ ] PR title follows type: short description convention

  • - [ ] Linked to relevant issue (closes #)

  • - [ ] Ready for review (not a draft)

@AradhyaTiwari10

Copy link
Copy Markdown
Contributor

A few issues to address before merging.

Issues to address

  1. DraftCard.tsx

const copyWithFallback = async (text: string) => {

The function is declared async but contains no await expressions. Remove the async keyword.

  1. DraftCard.tsx

aria-live="polite" is set on the button element. Live regions on interactive elements are not reliably announced by screen readers. Move it to a non-interactive sibling element that contains the status text.

  1. DraftCard.tsx

The DraftCard props in this PR (title, initialContent, onContentChange) differ from the existing interface (style, content, onContentChange). These interfaces are incompatible with the current usage. Please confirm this change is intentional and update the affected usages before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants