Add option for font/stroke color - #3
Open
len0rd wants to merge 2 commits into
Open
Conversation
len0rd
force-pushed
the
feature/len0rd/fontcolor
branch
from
February 6, 2025 15:49
2c87165 to
25d8969
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great project! Continue to use this across multiple Sphinx doc projects.
This PR adds an option for specifying the color to use for all outlines/strokes/fonts.
For instance running something like this:
python -m bit_field --fontcolor "#FF4500" --lanes 2 readme_alpha.jsonwill result in this SVG:
you can also use svg color names:
python -m bit_field --fontcolor blue --lanes 2 readme_alpha.jsonAnd the default remains as black:
python -m bit_field --lanes 2 readme_alpha.jsonI realize adding more functionality to something that's meant to be a direct port is not necessarily desirable. So i understand if you dont want to merge this in. I saw a need for this to make my bitfield diagrams more legible on dark-mode sites.