feat(suggest): add base item selection and 3-look comparison view - #194
Open
AmitayAbudy wants to merge 2 commits into
Open
feat(suggest): add base item selection and 3-look comparison view#194AmitayAbudy wants to merge 2 commits into
AmitayAbudy wants to merge 2 commits into
Conversation
- Allow generating outfit recommendations centered around a base clothing item (include_items) - Enforce mandatory base item retention in recommendation prompt and body slot deduplication - Add POST /api/v1/outfits/suggest-options to materialize and return all 3 AI options concurrently - Update suggestion cache key to incorporate include_items and support FIFO pop - Add item picker dialog to suggest dashboard and 'Create outfit with this item' action in wardrobe view - Add Look 1 / Look 2 / Look 3 tab navigation and side-by-side 'Compare All' grid view - Add full i18n translation coverage for all new UI strings across all 8 supported locales - Add unit and integration tests for include_items, suggest-options endpoint, and cache isolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the outfit suggestion experience by adding:
Features & Changes
POST /api/v1/outfits/suggest-options):include_items: list[UUID]in suggestion requests, forcing the AI prompt and outfit assembler to include the selected item(s).suggest:{user_id}:{occasion}:{sorted_item_ids}) and FIFO pop to isolate suggestions with specific base items./dashboard/suggest):item-detail-dialog.tsx) that routes directly to/dashboard/suggest?item=<id>.en,de,fr,it,ja,ko,zh-CN,zh-TW). Verified withnpm run i18n:check.include_itemsenforcement,suggest-optionsbatch endpoint, body-slot overrides, and suggestion cache isolation.Verification
npm run buildinfrontend/succeeds cleanly.npm run i18n:checkpasses with 0 missing keys / errors across all 8 locales.test_clothing_utils.py,test_suggestion_cache.py, andtest_recommendation_service.py.Summary by Sourcery
Improve outfit suggestions by supporting base-item-driven recommendations and comparison of three generated looks.
New Features:
Bug Fixes:
Enhancements:
Tests:
Chores: