Add support for --memory-limit= as a Client option on Linux#343
Draft
codedeliveryservice wants to merge 13 commits into
Draft
Add support for --memory-limit= as a Client option on Linux#343codedeliveryservice wants to merge 13 commits into
--memory-limit= as a Client option on Linux#343codedeliveryservice wants to merge 13 commits into
Conversation
Owner
|
Looks very solid. Might make some mostly cosmetic changes to the reporting, and to track in terms of kb (+var name). Going to wire this up with the bench_all, so I can hit some openbench frameworks with a slew of engines, and make sure everything goes as expected. Might need to slap something in there for Windows as well. Make take me some time to get to however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peak bench memory is measured as described in #337. To account for differences in hash size, each engine's default hash is fetched directly via
uciand subtracted from its requestedHash=....The option expects a value in MB (
--memory-limit 8192).If the estimation exceeds the limit, an exception is thrown and the workload is blacklisted on the client side, so it won't be requested again, e.g.: