Backport #104296 to Stable 25.8 - Disable additional_table_filters with parallel replicas and analyzer and w/o query plan serialization#2065
Draft
mkmkme wants to merge 2 commits into
Draft
Conversation
Disable additional_table_filters with parallel replicas and analyzer and w/o query plan serialization
25.8 is missing some of the settings that are used by the original PR. 25.8 is also missing the EXPLAIN-visualisation for parallel-replicas remote step, so the last query in the test doesn't actually check anything and is therefore dropped.
Collaborator
Author
|
Seems like fast test is failing. Will investigate |
mkmkme
marked this pull request as draft
July 17, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
additional_table_filterswith parallel replicas and analyzer and w/o query plan serialization. Previously it may lead to incorrect results.Analyzer rewrites query when sending to remotes (parallel replicas followers) to prepend database, and this breaks the
additional_table_filters. And there is no clean way to fix this w/o query plan serialization (serialize_query_plan=1). So it has been explicitly disabled (throw exception) for now.Fixes #2054
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disable
additional_table_filterswith parallel replicas and analyzer and w/o query plan serialization (ClickHouse#104296 by @azat)Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: