fix(playset): merge reprint editions into their canonical set - #8
Open
gjuillot wants to merge 1 commit into
Open
fix(playset): merge reprint editions into their canonical set#8gjuillot wants to merge 1 commit into
gjuillot wants to merge 1 commit into
Conversation
Adds EOLECB, WCQ25, WCS26, TCS3 and JUDGE to SET_ALIASES (whole-set reprints, visually confirmed as same-art editions). DUSTERTOP and MUSUBI needed a finer-grained CARD_ALIASES map instead, since each mixes cards reprinted from two different canonical sets rather than one. DUSTERCB was checked and excluded: it holds full-art alternates, not reprints, so it must not merge into DUSTER. Also fixes CollectionCardView::fillFromApiData() to derive cardSet from the reference itself when altered-core reports a null set (seen on EOLECB), instead of storing an empty string that silently dropped the row from every merge computation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug solved
In the "Physical playset" dashboard, some variations (alt arts) were not counted towards the completion of the playset. If full art are on purpose not counted in this dashboard (because with no text they are less usable in games), the alternative arts or the stamped cards (like Faction or WC) should.
Summary
EOLECB,WCQ25,WCS26,TCS3andJUDGEtoSET_ALIASES— whole-set reprints, each visually confirmed as the same standard-art edition as its canonical target.CARD_ALIASESmap forDUSTERTOPandMUSUBI, which each mix cards reprinted from two different canonical sets rather than one, so a single whole-token alias couldn't express them (verified card-by-card with zero ambiguity).DUSTERCB: visual inspection showed full-art alternates, not reprints, so it must not merge intoDUSTER.CollectionCardView::fillFromApiData()to derivecardSetfrom the reference itself when altered-core reports a nullset(seen onEOLECB), instead of storing''— which previously caused the row to be silently dropped from every merge computation (it never matchedWHERE card_set IN (:sets)).Test plan
phpunitsuite passes (same 6 pre-existing, unrelatedcardGroup-fixture failures as onmain, no new failures)SET_ALIASESandCARD_ALIASESmerges inCollectionPlaysetServiceTestandCollectionPlaysetCardsServiceTestcardSetnull-fallback inCollectionCardViewTest