Skip to content

fix(playset): merge reprint editions into their canonical set - #8

Open
gjuillot wants to merge 1 commit into
Altered-Community:mainfrom
gjuillot:fix/playset-set-aliases
Open

fix(playset): merge reprint editions into their canonical set#8
gjuillot wants to merge 1 commit into
Altered-Community:mainfrom
gjuillot:fix/playset-set-aliases

Conversation

@gjuillot

Copy link
Copy Markdown
Contributor

Bug solved

In the "Physical playset" dashboard, some variations (alt arts) were not counted towards the completion of the playset. If full art are on purpose not counted in this dashboard (because with no text they are less usable in games), the alternative arts or the stamped cards (like Faction or WC) should.

Summary

  • Adds EOLECB, WCQ25, WCS26, TCS3 and JUDGE to SET_ALIASES — whole-set reprints, each visually confirmed as the same standard-art edition as its canonical target.
  • Adds a new CARD_ALIASES map for DUSTERTOP and MUSUBI, which each mix cards reprinted from two different canonical sets rather than one, so a single whole-token alias couldn't express them (verified card-by-card with zero ambiguity).
  • Checked and excluded DUSTERCB: visual inspection showed full-art alternates, not reprints, so it must not merge into DUSTER.
  • Fixes CollectionCardView::fillFromApiData() to derive cardSet from the reference itself when altered-core reports a null set (seen on EOLECB), instead of storing '' — which previously caused the row to be silently dropped from every merge computation (it never matched WHERE card_set IN (:sets)).

Test plan

  • Full phpunit suite passes (same 6 pre-existing, unrelated cardGroup-fixture failures as on main, no new failures)
  • Added/updated unit tests for both SET_ALIASES and CARD_ALIASES merges in CollectionPlaysetServiceTest and CollectionPlaysetCardsServiceTest
  • Added a unit test for the cardSet null-fallback in CollectionCardViewTest

Adds EOLECB, WCQ25, WCS26, TCS3 and JUDGE to SET_ALIASES (whole-set
reprints, visually confirmed as same-art editions). DUSTERTOP and
MUSUBI needed a finer-grained CARD_ALIASES map instead, since each
mixes cards reprinted from two different canonical sets rather than
one. DUSTERCB was checked and excluded: it holds full-art alternates,
not reprints, so it must not merge into DUSTER.

Also fixes CollectionCardView::fillFromApiData() to derive cardSet
from the reference itself when altered-core reports a null set (seen
on EOLECB), instead of storing an empty string that silently dropped
the row from every merge computation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant