chore: remove unused httpx2 dev dependency#34
Open
Priyanshubhartistm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpx2>=2.5.0dev dependency frompyproject.tomland regenerateuv.lock.Why
pyproject.toml's[dependency-groups].devdeclaredhttpx2>=2.5.0, which looks like a typo for thehttpxpackage. Nothing insrc/ortests/importshttpx2— the HTTP-exercising tests (tests/test_ingest_workflow.py,tests/test_web_source_runtime.py) import plainhttpx, which is already a runtime dependency (httpx>=0.28.1). The stray dev dependency pulled its ownhttpx2,httpcore2, andtruststorepackages into everyuv syncand CI run for nothing, and a near-name package that shadows a real dependency in the manifest is confusing for anyone auditing the dependency tree.Related Issues #33
Verification
All passed:
uv sync --lockeduninstalledhttpx2/httpcore2/truststore;ruff checkreported no issues;pytestpassed 464/464;codealmanac --helpprinted the normal command list;uv buildproduced a valid wheel and sdist;twine checkpassed both artifacts;git diff --checkfound no whitespace issues.Docs and wiki
.almanac/wiki updated if an implementation decision, workflow, invariant, or gotcha changed.Notes for reviewers
Dependency-only change, no source or test code touched.
git grep -n httpx2 src testsconfirms zero usages before and after. Theuv.lockdiff looks large in line count, butgit diff uv.lock | grep '^[+-]name = 'shows only three package entries removed (httpx2,httpcore2,truststore) — the rest is the lockfile re-serializing after the dependency graph shrank.