Qwen model support - #150
Open
cv-chaitali wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for Qwen-family decoder models in tuned_lens.model_surgery by recognizing Qwen base-model structures that expose a decoder stack (layers) and final normalization (norm), unblocking LogitLens / PredictionTrajectory usage for Qwen models (as reported in issue #143).
Changes:
- Add a Qwen-family decoder detection helper and use it to route
get_final_norm()andget_transformer_layers()tobase_model.norm/base_model.layers. - Extend the test model fixture to include tiny Qwen2/Qwen3 (dense + MoE + Next) configs instantiated via
AutoModelForCausalLM.from_config. - Add a short documentation note with an example LogitLens result for
Qwen/Qwen3-0.6B.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tuned_lens/model_surgery.py | Adds Qwen decoder recognition and maps Qwen final norm/layers to base_model.norm and base_model.layers. |
| tests/conftest.py | Adds tiny Qwen config helpers and includes Qwen2/Qwen3 variants in the randomized small-model test fixture. |
| docs/qwen-support/README.md | Documents the motivating error/issue and summarizes the Qwen support changes and a sample result. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Qwen-family decoder models in
tuned-lens.Changes
base_model.normandbase_model.layersQwen/Qwen3-0.6BLogitLens resultRelated issue: #143