chore(fork): prune NVIDIA-only CI and record the upstream base - #2
Open
taufeeque9 wants to merge 2 commits into
Open
chore(fork): prune NVIDIA-only CI and record the upstream base#2taufeeque9 wants to merge 2 commits into
taufeeque9 wants to merge 2 commits into
Conversation
Every GitHub workflow upstream ships is NVIDIA-org automation: gated on github.repository == 'NVIDIA/Megatron-LM', or dependent on FW-CI-templates, copy-pr-bot, self-hosted runners, and org secrets (PAT, NVIDIA_INFERENCE_*, TWINE_PASSWORD, Slack webhooks). None of it can run on this fork, so all of .github/workflows/ goes, along with CODEOWNERS (names @NVIDIA/* teams that do not exist here) and copy-pr-bot.yaml. The GitLab CI (.gitlab-ci.yml, .gitlab/) is inert on GitHub and stays, as do the workflow helpers under .github/actions/ and .github/scripts/ — deleting them would only add conflict surface on upstream syncs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
.fork-base.json records the upstream commit farai/main sits on (d12f6c8, verified as the unique merge-base with NVIDIA/Megatron-LM main). NeMo-RL pins this repo as a submodule and reads that record to decide compatibility. tools/fork_base.py and tools/sync_upstream.sh are dropped in unchanged from the nemo-rl copy; the fork-base workflow follows nemo-gym's variant (checkout pinned by SHA, no PAT — this repo has no private submodules). The Makefile is fork-only: upstream ships none. Rolled out from AlignmentResearch/nemo-gym#16, which itself rolled out megatron-bridge-internal#3. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets this repo up as a FAR.AI fork: prunes the upstream CI that cannot run here and rolls out the
fork-basemanifest and tooling, mirroring nemo-gym#16 (which rolled out the pattern from megatron-bridge-internal#3).Changes
workflows/config/): every one is NVIDIA-org automation — gated ongithub.repository == 'NVIDIA/Megatron-LM', or needingFW-CI-templates,copy-pr-bot, self-hosted runners, or org secrets (PAT,NVIDIA_INFERENCE_*,TWINE_PASSWORD, Slack webhooks). AlsoCODEOWNERS(names@NVIDIA/*teams that do not exist here) andcopy-pr-bot.yaml..gitlab-ci.yml,.gitlab/), which does not run on GitHub — it is inert here, and deleting it would only add conflict surface on every upstream sync. Same for the workflow helpers under.github/actions/and.github/scripts/..fork-base.jsond12f6c8c). Changes only when upstream is merged in.tools/fork_base.py--write/--check/--print. Dropped in unchanged from the nemo-rl copy.tools/sync_upstream.shmake sync-upstream— merges newer upstream onto async/upstream-<date>-<sha>branch and regenerates the manifest. Unchanged from the other forks..github/workflows/fork-base.yml--checkon every PR and push tofarai/main. Publishes the status contextfork-base. Follows nemo-gym's variant: checkout pinned by SHA, no PAT (this repo has no private submodules).Makefile,README.farai.mdmake helplists the commands; the README carries the fork workflow and patch list. Upstream ships no Makefile, so this one is fork-only.Out of scope
No unit-test-suite bring-up (nemo-gym#16's sharded-suite step has no analogue here): Megatron-LM's tests are GPU-bound, so there is nothing runnable on GitHub-hosted runners.
Relationship to #1
#1 (
tf-at/moe-lora-stack-on-d12f6c8c) is the pending expert-LoRA GEMM stack + hybrid-recompute guard series and is listed as such inREADME.farai.md. This PR should merge first; once it does, #1's merge ref carries the manifest and thefork-basecheck applies to it.Verification
farai/mainsits exactly on upstream commitd12f6c8c9aff51e166d872fd70151687a8e3f375("Add generic interface for SSM inference (Add generic interface for SSM inference NVIDIA/Megatron-LM#5382)"):git merge-base origin/farai/main upstream/mainreturns it, andmerge-base --allreturns exactly one commit.python3 tools/fork_base.py --checkpasses locally, in both plain and PR (--against origin/farai/main) modes — the latter reports the expected bootstrap note (target has no manifest yet).bash -n tools/sync_upstream.shpasses;fork-base.ymlparses as YAML.🤖 Generated with Claude Code