[PWGLF] [PWG:LF] Added the THnSparse for MC Closure test by navneetkumar231295 · Pull Request #17105 · AliceO2Group/O2Physics

navneetkumar231295 · 2026-07-17T09:24:53Z

No description provided.

github-actions · 2026-07-17T09:25:11Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild · 2026-07-17T10:20:12Z

Error while checking build/O2Physics/code-check for c856fac at 2026-07-17 12:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 88 warnings.'
Found 10 errors and 88 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/b43b9130f13f8c7ee1f6b677275780b1e651089d/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:77:8: error: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:724:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:817:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:824:11: error: variable 'theta2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1421:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1448:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1552:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1576:23: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1620:11: error: implicit conversion 'size_type' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1620:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
++ [[ 88 -gt 0 ]]
++ cat /sw/BUILD/b43b9130f13f8c7ee1f6b677275780b1e651089d/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:632:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:634:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:641:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:645:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:647:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:649:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:651:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:653:105: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:655:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:657:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:660:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:662:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:664:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:667:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:669:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:672:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:674:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:676:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:678:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:681:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:683:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:688:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:691:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:697:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:700:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:710:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:712:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:714:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:759:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:883:44: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

alibuild · 2026-07-17T10:30:55Z

Error while checking build/O2Physics/code-check for d66dc8b at 2026-07-17 12:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 88 warnings.'
Found 10 errors and 88 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/edf7c747478e503450e417522b179a78c0375500/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:77:8: error: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:724:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:817:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:824:11: error: variable 'theta2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1421:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1448:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1552:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1576:23: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1620:11: error: implicit conversion 'size_type' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1620:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
++ [[ 88 -gt 0 ]]
++ cat /sw/BUILD/edf7c747478e503450e417522b179a78c0375500/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:632:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:634:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:641:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:645:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:647:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:649:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:651:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:653:105: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:655:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:657:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:660:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:662:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:664:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:667:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:669:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:672:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:674:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:676:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:678:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:681:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:683:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:688:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:691:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:697:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:700:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:710:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:712:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:714:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:759:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:883:44: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

alibuild · 2026-07-17T10:37:55Z

Error while checking build/O2Physics/code-check for 5c0d2be at 2026-07-17 12:37:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 88 warnings.'
Found 10 errors and 88 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/9a2f45d2575ef8d98f11ddd48cf5ebcc3958f0b8/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:77:8: error: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:724:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:817:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:824:11: error: variable 'theta2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1421:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1448:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1552:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1576:23: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1620:11: error: implicit conversion 'size_type' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:1620:24: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
++ [[ 88 -gt 0 ]]
++ cat /sw/BUILD/9a2f45d2575ef8d98f11ddd48cf5ebcc3958f0b8/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:632:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:634:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:641:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:645:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:647:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:649:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:651:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:653:105: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:655:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:657:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:660:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:662:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:664:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:667:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:669:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:672:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:674:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:676:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:678:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:681:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:683:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:688:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:691:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:697:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:700:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:710:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:712:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:714:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:759:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/chargedkstaranalysis.cxx:883:44: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Added the THnSparse for MC Closure test

9bab3f6

navneetkumar231295 requested review from alibuild, dmallick2, mpuccio, omvazque, prottayCMT, skundu692 and smaff92 as code owners July 17, 2026 09:24

github-actions Bot added the pwglf label Jul 17, 2026

github-actions Bot changed the title ~~[PWG:LF] Added the THnSparse for MC Closure test~~ [PWGLF] [PWG:LF] Added the THnSparse for MC Closure test Jul 17, 2026

navkumar123 added 2 commits July 17, 2026 15:07

To solve the linter error

bdce618

To solve the linter error

c856fac

alibuild mentioned this pull request Jul 17, 2026

[PWGLF] Please consider the following formatting changes to #17105 navneetkumar231295/O2Physics#10

Closed

To solve the white space error

d66dc8b

To solve the bug

5c0d2be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PWGLF] [PWG:LF] Added the THnSparse for MC Closure test#17105

[PWGLF] [PWG:LF] Added the THnSparse for MC Closure test#17105
navneetkumar231295 wants to merge 5 commits into
AliceO2Group:masterfrom
navneetkumar231295:master

navneetkumar231295 commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

alibuild commented Jul 17, 2026

Uh oh!

alibuild commented Jul 17, 2026

Uh oh!

alibuild commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

navneetkumar231295 commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

alibuild commented Jul 17, 2026

Uh oh!

alibuild commented Jul 17, 2026

Uh oh!

alibuild commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants