Skip to content

[ALICE3] Add process function to a3multicharm finding subscribing to strangeness builder output#17092

Merged
jesgum merged 3 commits into
AliceO2Group:masterfrom
jesgum:a3-multicharm-dev
Jul 16, 2026
Merged

[ALICE3] Add process function to a3multicharm finding subscribing to strangeness builder output#17092
jesgum merged 3 commits into
AliceO2Group:masterfrom
jesgum:a3-multicharm-dev

Conversation

@jesgum

@jesgum jesgum commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 39 errors, ⚠️ 22 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add process function to a3multicharm finding subscribing to strangeness builder output [ALICE3] Add process function to a3multicharm finding subscribing to strangeness builder output Jul 16, 2026
@jesgum
jesgum marked this pull request as ready for review July 16, 2026 13:52
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5d07319 at 2026-07-16 16:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 81 errors and 15 warnings.'
Found 81 errors and 15 warnings.
++ [[ 81 -gt 0 ]]
++ cat /sw/BUILD/9b03622193fec94e9189f8eec45e8f1227fb7da0/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:104:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:109:9: error: function-like macro 'getHist' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:110:28: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:111:9: error: variadic macro 'fillHist' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:116:9: error: variadic macro 'insertHist' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:131:8: error: constructor does not initialize these fields: thisCascade, thisV0, pdgDB, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:270:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:273:9: error: constructor does not initialize these fields: mcLabel, isDecayDau, isWeakDecayDau, isUsedInCascading, nSiliconHits, nTPCHits, trackType [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:298:5: error: function 'getTimeMUS' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:402:15: error: member 'timeResolutionNs' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:403:15: error: member 'nsToMus' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:404:15: error: member 'timeResolutionUs' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:428:27: error: use starts_with instead of find [modernize-use-starts-ends-with,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:688:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:696:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:740:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:742:53: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:766:36: error: the parameter 'particle' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:773:11: error: variable 'sna' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:773:16: error: variable 'csa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:817:39: error: the parameter 'particle' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:870:90: error: the const qualified parameter 'histPath' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:931:5: error: uninitialized record type: 'isReco' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:932:5: error: uninitialized record type: 'nHitsCascadeProngs' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:933:5: error: uninitialized record type: 'nSiliconHitsCascadeProngs' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:934:5: error: uninitialized record type: 'nTPCHitsCascadeProngs' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1022:9: error: do not use 'else' after 'continue' [readability-else-after-return,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1077:9: error: uninitialized record type: 'pos' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1078:9: error: uninitialized record type: 'posCascade' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1079:9: error: uninitialized record type: 'posP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1080:9: error: uninitialized record type: 'negP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1081:9: error: uninitialized record type: 'bachP' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1105:19: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1199:15: error: uninitialized record type: 'posClusterCandidate' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1217:15: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1250:92: error: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1252:9: error: uninitialized record type: 'pCasc' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1253:9: error: uninitialized record type: 'pBach' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1254:9: error: uninitialized record type: 'pV0' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1310:11: error: redundant condition 'reconstructedCascade' [bugprone-redundant-branch-condition,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1409:23: error: unused local variable 'histPath' of type 'const std::string' (aka 'const basic_string<char>') [bugprone-unused-local-non-trivial-variable,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:1426:11: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@jesgum
jesgum enabled auto-merge (squash) July 16, 2026 14:59

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@jesgum
jesgum merged commit a322d7e into AliceO2Group:master Jul 16, 2026
13 of 17 checks passed
@jesgum
jesgum deleted the a3-multicharm-dev branch July 16, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants