Skip to content

Fix invalid default values for InputBoolean objects in IOP - #68

Merged
sujandumaru merged 1 commit into
developfrom
copilot/ticket-range-error
Aug 13, 2026
Merged

Fix invalid default values for InputBoolean objects in IOP#68
sujandumaru merged 1 commit into
developfrom
copilot/ticket-range-error

Conversation

Copilot AI commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

All four InputBoolean objects in AOG_TC.iop had a default value of 24 (0x18) instead of a valid boolean 0 or 1. This is likely a font-size attribute that was incorrectly written into the value field by the IOP authoring tool.

Changes

  • resources/AOG_TC.iop — patched the value byte at the confirmed binary offset for each of the four affected objects:
ID Name Before After
10001 ConfigHydliftAuxN 24 0
10002 ConfigNmeaRead 24 0
10003 ConfigNmeaSend 24 1
10004 ConfigTecuEnabled 24 1

ConfigNmeaSend and ConfigTecuEnabled default to 1 to match DEFAULT_NMEA_SEND_ENABLED = true and DEFAULT_TECU_ENABLED = true in settings.hpp. The other two default to 0 as they are not yet implemented (inputs are disabled).

Co-authored-by: gunicsba <3919203+gunicsba@users.noreply.github.com>
@sujandumaru

sujandumaru commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Good finding. The .iop is still new and will likely need more changes, so I'd like to put a guard in TC to test the basic properties of the iop objects in TC itself rather than catching this on hardware again.

Worth noting AgIsoStack does report this. It goes to Failed and logs the faulty object ID from the End of Object Pool response. I checked get_is_valid() against the broken pool and it returns 0 failures, since value=24 is structurally valid and only semantically illegal for a boolean.

Let me work on a small CI validator, before approving this, that will range-checks attributes against their ISO limits and some other basic properties that fails with current iop file and passes after merging your change. Would be helpful in future as well if we decide to make some changes on .iop file.

@sujandumaru
sujandumaru merged commit e2ab356 into develop Aug 13, 2026
5 checks passed
@sujandumaru
sujandumaru deleted the copilot/ticket-range-error branch August 13, 2026 05:47
@gunicsba

Copy link
Copy Markdown
Contributor

Yes ideally there should be a check in CI that would return the validity of the iop files. It's not just for TC but any project that includes iop like ECUs or even the agisostack examples.
So that's why I created a ticket on the library itself as well.

@gunicsba gunicsba linked an issue Aug 15, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kverneland Tellus can't load VT

3 participants