Fix invalid default values for InputBoolean objects in IOP - #68
Conversation
Co-authored-by: gunicsba <3919203+gunicsba@users.noreply.github.com>
|
Good finding. The Worth noting AgIsoStack does report this. It goes to Let me work on a small CI validator, before approving this, that will range-checks attributes against their ISO limits and some other basic properties that fails with current iop file and passes after merging your change. Would be helpful in future as well if we decide to make some changes on |
|
Yes ideally there should be a check in CI that would return the validity of the iop files. It's not just for TC but any project that includes iop like ECUs or even the agisostack examples. |
All four
InputBooleanobjects inAOG_TC.iophad a defaultvalueof24(0x18) instead of a valid boolean0or1. This is likely a font-size attribute that was incorrectly written into the value field by the IOP authoring tool.Changes
resources/AOG_TC.iop— patched thevaluebyte at the confirmed binary offset for each of the four affected objects:ConfigHydliftAuxN0ConfigNmeaRead0ConfigNmeaSend1ConfigTecuEnabled1ConfigNmeaSendandConfigTecuEnableddefault to1to matchDEFAULT_NMEA_SEND_ENABLED = trueandDEFAULT_TECU_ENABLED = trueinsettings.hpp. The other two default to0as they are not yet implemented (inputs are disabled).