Legacy SC via element DDI 141 set for Müller SC BOX - #65
Open
gunicsba wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Adding so we can fetch it on the tablet |
sujandumaru
reviewed
Jul 22, 2026
| // For legacy per-element devices: propagate to section actual states | ||
| // so the heartbeat (PGN 0xF0) can report them to AOG | ||
| std::uint8_t sectionIndex; | ||
| if (clients[partner].try_get_section_for_element(elementNumber, sectionIndex)) |
Collaborator
There was a problem hiding this comment.
I think we need to enforce clients[partner].uses_per_element_control() check here as well. It works for legacy per-element devices, but I believe a modern implement can report the condensed work state (161/290) and DDI 141 on the same element, and then this block runs for it too which might messed up some section actual state for modern implement.
sujandumaru
reviewed
Jul 22, 2026
| constexpr static std::array<std::uint8_t, 3> DEFAULT_SUBNET = { 192, 168, 5 }; | ||
| constexpr static bool DEFAULT_TECU_ENABLED = true; | ||
| constexpr static bool DEFAULT_AOG_HEARTBEAT_ENABLED = true; | ||
| constexpr static bool DEFAULT_AOG_HEARTBEAT_ENABLED = false; |
Collaborator
There was a problem hiding this comment.
Do we need to change this default value?
Contributor
Author
There was a problem hiding this comment.
Yes because there's a bug somewhere in AgOpenGPS and we often need to have this as false.
Collaborator
There was a problem hiding this comment.
Is there more detail regarding this bug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we got it working and it's bidirectional.