Hackathon integration tests for checkout Test environment

[poojah-adyen]

Description

Tested scenarios

Fixed issue:

[gemini-code-assist]

Code Review

This pull request introduces a structured integration testing framework using Maven Failsafe, adding comprehensive documentation, configuration templates, and concrete integration tests for Checkout and Cloud Device APIs. Key feedback includes caching and properly closing the Client instance in BaseIntegrationTest to prevent resource leaks, safely loading classpath resources, supporting Java System properties for configuration overrides, and removing accidental system prompt tags from the documentation.

[gemini-code-assist]

The getClient() method currently instantiates a new Client on every call. Since Client holds an underlying HTTP client with connection pools and threads, creating multiple unclosed instances can lead to resource leaks (such as socket or thread exhaustion) and slower test execution due to repeated TLS handshakes. Caching the client instance and closing it after each test using @AfterEach resolves these issues and improves performance through connection reuse.

  private Client client;

  protected final Client getClient() {
    if (client == null) {
      Environment environment = getEnvironment();
      Config config = new Config().apiKey(getApiKey()).environment(environment);

      String liveEndpointUrlPrefix = getOptionalProperty(LIVE_ENDPOINT_URL_PREFIX_PROPERTY);
      if (environment == Environment.LIVE && liveEndpointUrlPrefix != null) {
        config.liveEndpointUrlPrefix(liveEndpointUrlPrefix);
      }

      client = new Client(config);
    }
    return client;
  }

  @AfterEach
  protected void tearDownClient() throws IOException {
    if (client != null) {
      client.close();
      client = null;
    }
  }

[gemini-code-assist]

Add the org.junit.jupiter.api.AfterEach import to support tearing down and closing the cached Client instance after each test execution.

Suggested change

	import com.adyen.enums.Environment;
	import java.io.IOException;
	import java.io.InputStream;
	import java.util.Locale;
	import java.util.Properties;
	import com.adyen.enums.Environment;
	import java.io.IOException;
	import java.io.InputStream;
	import java.util.Locale;
	import java.util.Properties;
	import org.junit.jupiter.api.AfterEach;

[gemini-code-assist]

Using BaseIntegrationTest.class.getClassLoader() can potentially return null if the class is loaded by the bootstrap classloader. It is safer and more idiomatic to use BaseIntegrationTest.class.getResourceAsStream with a leading slash to load classpath resources defensively.

Suggested change

	try (InputStream inputStream =
	BaseIntegrationTest.class.getClassLoader().getResourceAsStream(CONFIGURATION_RESOURCE)) {
	try (InputStream inputStream =
	BaseIntegrationTest.class.getResourceAsStream("/" + CONFIGURATION_RESOURCE)) {

[gemini-code-assist]

The configuration lookup currently only checks environment variables and the properties file. It does not check Java System properties (System.getProperty(name)). Adding System properties to the lookup chain allows developers to easily override configuration values via standard Maven command-line flags (e.g., -DADYEN_API_KEY=...).

  private static String getOptionalProperty(String name) {
    String property = System.getenv(name);
    if (property == null || property.isBlank()) {
      property = System.getProperty(name);
    }
    if (property == null || property.isBlank()) {
      property = PROPERTIES.getProperty(name);
    }
    return property == null || property.isBlank() ? null : property;
  }

[gemini-code-assist]

The XML-like tags <integration_test_guidelines> at the beginning of the file and </integration_test_guidelines> at the end of the file appear to be system prompt artifacts that were accidentally committed. They should be removed to keep the markdown clean and professional.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud