chore(dependencies) fix issues raised by dependency:analyze - #2034
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies in pom.xml, including Jackson, Apache HttpComponents, Okio, and JUnit. The review feedback points out that replacing the junit-jupiter aggregator with individual modules requires adding junit-jupiter-engine to prevent tests from being silently skipped. Additionally, it recommends aligning the Jackson dependency versions by reusing the existing ${com.fasterxml.jackson-version} property and removing the redundant com.fasterxml.jackson-annotations-version property.
jeandersonbc
force-pushed
the
dependency-cleanup
branch
3 times, most recently
from
August 11, 2026 12:57
d2547a4 to
708f0b1
Compare
jeandersonbc
enabled auto-merge
August 11, 2026 14:37
jeandersonbc
commented
Aug 11, 2026
This PR runs cleans up used (but not declared, i.e., transitive) dependencies by explicitly declaring it and removes declared (but not used, i.e., stale) dependencies by removing them. In addition, adds `mvn dependency:analyze -DfailOnWarnings=true` to ensure dependencies are always correct. Junit Platform is a false-negative because it is handled via ServiceLoader. Our surefire version makes it redundant (that's why tests remain running without it) but for safety, we explicitly add it and use the dependency plugin to ignore it from analysis.
jeandersonbc
force-pushed
the
dependency-cleanup
branch
from
August 11, 2026 15:34
708f0b1 to
44b87f8
Compare
gcatanese
approved these changes
Aug 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs cleans up used (but not declared, i.e., transitive) dependencies by explicitly declaring it and removes declared (but not used, i.e., stale) dependencies by removing them. In addition, adds
mvn dependency:analyze -DfailOnWarnings=trueto ensure dependencies are always correct.