Skip to content

intentional broken accordion #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davids-ensemble wants to merge 5 commits into
base: playwright-setup-DEVSITE-2549
Choose a base branch
from
Draft

intentional broken accordion #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e20a139
intentional broken accordion
davids-ensemble Aug 25, 2026
cb270fb
Merge branch 'playwright-setup-DEVSITE-2549' of github.com:AdobeDocs/…
davids-ensemble Sep 8, 2026
4aee93b
Merge branch 'playwright-setup-DEVSITE-2549' of github.com:AdobeDocs/…
davids-ensemble Sep 8, 2026
f98f2d9
modify announcement
davids-ensemble Sep 8, 2026
73e015a
Merge branch 'playwright-setup-DEVSITE-2549' of github.com:AdobeDocs/…
davids-ensemble Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions hlx_statics/blocks/accordionitem/accordionitem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,9 @@ function decorateTables(block) {
function getAccordionItem(heading) {
return `
<h3>
<button class="accordion-itemHeader" type="button">
<button class="accordion-itemHeader" type="button">
<span class="accordion-toggle-icon">
<svg class="expand-icon" style="display: block;" width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M8 3V13M3 8H13" stroke="currentColor" stroke-width="2" stroke-linecap="round"/>
</svg>
<svg class="collapse-icon" style="display: none;" width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M3 8H13" stroke="currentColor" stroke-width="2" stroke-linecap="round"/>
Expand All @@ -129,7 +128,7 @@ export default async function decorate(block) {
item.setAttribute("class", "accordion-item");
const heading = item.querySelector('h3, h4, h5, h6');
if (heading) {
const headingText = heading?.innerText;
const headingText = heading?.innerText + "bug";
item.innerHTML = getAccordionItem(headingText);
item.setAttribute("class", "accordion-itemHeader");
} else {
Expand Down
2 changes: 1 addition & 1 deletion hlx_statics/blocks/announcement/announcement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function rearrangeLinks(block) {
const announcementButtonContainer = document.createElement('div');
announcementButtonContainer.classList.add('announcement-button-container');

leftDiv.querySelectorAll('ul').forEach((ul) => {
leftDiv.querySelectorAll('ul, ul').forEach((ul) => {
ul.querySelectorAll('li a').forEach((a, index) => {
const pTag = document.createElement('p');
if (index === 0 && variant !== 'secondary') {
Expand Down
Loading