fix: prevent shell injection from context expressions in run blocks - #40
Merged
Merged
Conversation
melissag-ensemble
changed the title
melissag-ensemble
changed the title
melissag-ensemble
force-pushed
the
security/yaml-context-injection
branch
2 times, most recently
from
May 26, 2026 16:36
4ef8964 to
e42496c
Compare
louisachu
approved these changes
May 26, 2026
melissag-ensemble
force-pushed
the
security/yaml-context-injection
branch
from
May 26, 2026 20:15
e42496c to
ab63d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
${{ }}context expressions out ofrun:blocks and into siblingenv:blocks, per GitHub's security hardening guide. Flagged by security review on commerce-php#451.Ticket
https://jira.corp.adobe.com/browse/DEVSITE-2433
Related PRs
Notes
GitHub substitutes
${{ }}into the YAML before the shell parses it. Theenv:pattern passes the value as plain data instead, so shell metacharacters can't execute.Test
https://github.com/AdobeDocs/adp-devsite-github-actions-test/actions/runs/26468085998/job/77933754731