League of Legends throws unexpected error when AdGuard is enabled - #69
Open
AlexandrPkhm wants to merge 2 commits into
Open
League of Legends throws unexpected error when AdGuard is enabled#69AlexandrPkhm wants to merge 2 commits into
AlexandrPkhm wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends the Windows route-exclusions app definitions to cover Riot Games components implicated in issue #68, aiming to prevent AdGuard traffic routing from causing login/runtime errors in League of Legends and related Riot processes.
Changes:
- Added new route-exclusion app entries for Riot Client, League of Legends, and Riot Vanguard.
- Introduced registry/file-based installation detection and executable name lists for the new entries.
- Linked the new entries to the public CompatibilityIssues report (#68).
Suppressed comments (1)
windows/route_exclusions_apps.json:445
- The PR description says the League of Legends entry includes both registry- and file path-based installation checks, but the entry currently contains only registry checks. If file path-based detection is intended (also matching the issue report’s suggested paths), add
FilePathconditions for common install locations (keeping the existing registry checks as fallbacks).
"installed_conditions": [
{
"type": "RegistryKey",
"pattern": "HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Riot Game league_of_legends.live"
},
{
"type": "RegistryKey",
"pattern": "HKEY_LOCAL_MACHINE\\Software\\Riot Games, Inc\\League of Legends"
},
{
"type": "RegistryKey",
"pattern": "HKEY_LOCAL_MACHINE\\Software\\Wow6432Node\\Riot Games, Inc\\League of Legends"
}
],
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three entries to
windows/route_exclusions_apps.jsonso that "Route traffic through AdGuard" is OFF by default for Riot Games titles. Reporter confirmed this exact executable set resolves the LoL login "unexpected error".RiotClientServices.exe,RiotClientUx.exe,RiotClientUxRender.exeLeagueClient.exe,LeagueClientUx.exe,LeagueClientUxRender.exe,League of Legends.exevgc.exe,vgm.exeWhy three entries, not one: Riot Client (shared login for LoL/TFT/VALORANT/LoR/2XKO), League of Legends and Riot Vanguard are separate products with separate install roots and separate install-detection keys.
installed_conditionsare OR-ed, so merging them would either mislabel rows or miss installs, and users should be able to unroute the launcher independently of the game.Detection notes: the install root is user-selectable (default
C:\Riot Games\, not%PROGRAMFILES%), so the games are detected via registry keys only.FilePathis used only for the fixed-location Vanguard install and the legacy%PROGRAMFILES(x86)%\Riot Gamesroot.Reviewer question — Vanguard: this repo's precedent (PUBG/BattlEye, Arknights: Endfield/Tencent ACE) is to omit anti-cheat executables.
vgc.exeandvgm.exeare included here because the reporter confirmed them and Riot'sown firewall article lists both as network-facing.