fix: Custom checker code - #22
Merged
Merged
Conversation
First, arguments should be `bytes` instead of strings to match the dmoj API Second, we are writing the arguments to files that our Python wrapper can read instead of using argv, which could be too large for some problems
There was a problem hiding this comment.
Pull request overview
This PR updates custom checker execution to avoid passing large checker arguments through argv and to align checker inputs with the DMOJ-style bytes API.
Changes:
- Adds a Python wrapper that reads checker inputs from files.
- Writes solution output and expected output to temporary files before invoking the checker.
- Passes the original input file path to the wrapper instead of piping stdin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove utf-8 roundtrip - Change PathBuf reference to Path - Run cargo fmt
rayokamoto
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two custom checker bugs:
bytesinstead of strings to match the dmoj API