Added new feature - merging articles - #31
Open
kdefliese wants to merge 32 commits into
Open
Conversation
| @article_1.merge_with(params[:merge_with]) | ||
| flash[:notice] = _('Article was successfully merged') | ||
| redirect_to :action => 'index' | ||
| elsif Article.find_by_id(params[:merge_with]).nil? |
There was a problem hiding this comment.
So you're doing two find_by_ids here, which is going to make the same database query twice. I'd recommend storing the result of this above the conditional so it will only do this database query once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature is complete and deployed to heroku - https://git.heroku.com/shielded-hollows-15125.git
Cucumber tests are complete and green for everything except checking to see that comments are merged (haven't added a test for this yet)
Specs are incomplete