fix(ui): prevent dashboard chrome overlap at narrow viewports - #1756
fix(ui): prevent dashboard chrome overlap at narrow viewports#1756erichroepke wants to merge 2 commits into
Conversation
|
Resolve by running |
…se (Abilityai#1754) The compact hamburger never opened on a normal click: clicking the icon targets the <path> inside the trigger, and the v-if/v-else icon swap detaches that node from the DOM before the document click-outside handler runs. navRef.contains(detachedTarget) then returns false, so the guard treated the opening click as an outside click and closed the panel the instant it opened — leaving every primary route unreachable below xl. Add @click.stop to the trigger so the opening click never reaches handleClickOutside. Closing still works via toggle, outside-click on other elements, Escape, and route change. The PR's own @smoke test (compact navigation keeps routes reachable) now passes; all 4 dashboard-responsive smoke tests green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Pushed a fix commit ( The one blocker was the compact hamburger — it never opened on a normal click, which matters because this PR moves the desktop route strip to Root cause (confirmed by instrumenting the handlers):
Proof: clicking the button's padding corner (target = the Fix is one line — Your own Two notes for the record, neither blocking:
Ready for approval once someone else signs off. |
Description
Fix the narrow-desktop responsive layout across Trinity's shared navigation, Dashboard summary/control bar, and Replay Timeline.
The change:
Related issue
Fixes #1754
Type of change
Testing
devat714 × 863: Settings/status intersected, toolbar overflowed by 140px, and header border was 0px.devat 375, 639, 640, 700, 714, 768, 1024, 1100, 1101, 1279, 1280, and 1440px.99+badge, outside-click closure, Escape closure, and focus return.e2e/dashboard-responsive.spec.jsto the@smokeCI set.npm run check:tokensnpm run build--grep @smoke --listnpm run test:e2e:smokelocally (admin credential was intentionally not exposed; CI will execute it)Checklist