ICARTT v2 - #1053
Open
jrobrien91 wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
Hmm not letting me include the written sample .ict file. I'll send over internally |
zssherman
requested changes
Aug 27, 2026
zssherman
reviewed
Aug 27, 2026
Collaborator
Author
|
Still need to add the scaling factor function but will do so in the morning; other suggested corrections applied |
Collaborator
Author
|
Scale factor function created for the incredibly rare chance someone wants to use a non-one scale factor. The caveat on this is it does not touch the upper and lower detection limit flags, which will always be -7777 and -8888 |
zssherman
self-requested a review
August 28, 2026 17:23
zssherman
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the icartt library dependency from ACT, creating an new Icartt class within
act/io/icartt.pythat allows for reading and writing of FFI 1001 data.write_icarttis an entirely new function designed to close the loop between ARM netcdf and ICARTT formatted files.Why
Closes ACT 2.0 roadmap remaining item (
write_icartt).Also, greatly improves testing of the icartt class, particularly the handling of special comment lines
Issues closed
Closes #1051
Validation
Mark each item as done or N/A. Add one short evidence line for each item.
I ran pre-commit or ruff
I ran tests and/or added tests
AI usage & manual verification
If AI tools were used, complete this section.
icarttfrom the continuous integration and docs environments.joe.ictwas included within this markdown for visual inspection against the ARM Test Data repo. This file was generated viawrite_icarttafter reading in the ARM AAF ICARTT file.Impact note (optional):
- there is not a change for users using the
read_icarttfunction. However, the icartt library dependency is removed.