Skip to content

Hoist the eb_flow tracer device vector out of the MFIter loop. #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WeiqunZhang merged 1 commit into from
Aug 19, 2026
+9 −8
Merged

Hoist the eb_flow tracer device vector out of the MFIter loop. #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/boundary_conditions/incflo_set_bcs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,15 @@ incflo::set_eb_tracer (int lev, Real /*time*/, MultiFab& eb_tracer, int nghost)
const auto& factory =
dynamic_cast<EBFArrayBoxFactory const&>(eb_tracer.Factory());

// These are box-independent, and must outlive every kernel launched in the
// MFIter loop below, which captures eb_flow_tracer.
int num_trac = m_ntrac;
Gpu::DeviceVector<Real> eb_flow_tracer_dv;
for(int n(0); n < num_trac; ++n) {
eb_flow_tracer_dv.push_back(m_eb_flow.tracer[n]);
}
Real* eb_flow_tracer = eb_flow_tracer_dv.data();

#ifdef _OPENMP
#pragma omp parallel if (Gpu::notInLaunchRegion())
#endif
Expand All @@ -387,14 +396,6 @@ incflo::set_eb_tracer (int lev, Real /*time*/, MultiFab& eb_tracer, int nghost)
Real norm_tol_lo = Real(-1.) - (normal_tol + pad);
Real norm_tol_hi = Real(-1.) + (normal_tol + pad);

int num_trac = m_ntrac;
// Create a device vector
Gpu::DeviceVector<Real> eb_flow_tracer_dv;
for(int n(0); n < num_trac; ++n) {
eb_flow_tracer_dv.push_back(m_eb_flow.tracer[n]);
}
Real* eb_flow_tracer = eb_flow_tracer_dv.data();

ParallelFor(bx, [flags_arr,eb_tracer_arr,norm_arr,has_normal,normal,
norm_tol_lo, norm_tol_hi, num_trac, eb_flow_tracer]
AMREX_GPU_DEVICE (int i, int j, int k) noexcept
Expand Down
Loading