records: land FaithC, nothing outstanding - #44
Closed
jeffdaily wants to merge 9 commits into
Closed
Conversation
…erified against the live PR head)
Collaborator
Author
|
I reject the proposed change to validation.md. It bakes in the Windows ROCm PyTorch wheel version used for validation. Validating the cuda build isn't broken should be done on a linux platform rather than windows, for ease. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the completed control-plane records for FaithC plus one riding lesson.
review-passed, no waivers, no open deferrals.5e7e93aa3(wave64, wave32, windows gates satisfied).validation.mdlesson (this is the counterpart of the one that landed with accelerated-scan records: land accelerated-scan, nothing outstanding #30; if they read as duplicates after this merge, consolidating them is a welcome follow-up).Records-only otherwise, under
projects/FaithC/.Part of the misplaced-branch sweep.
🤖 Generated with Claude Code