fix: clean up cancelled CDP commands - #235
Open
one241 wants to merge 1 commit into
Open
Conversation
Collaborator
|
need fix format issue, make ci pass @one241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pending CDP commands are rejected when the debugger detaches, but their timeout and abort resources are not consistently cleaned up. Late Chrome callbacks can also attempt to settle commands that have already timed out or been cancelled.
Root cause
The pending-command registry stores raw reject callbacks and each completion path performs only partial cleanup. There is no shared single-settlement guard or AbortSignal integration.
Changes
Tests
Note: the pre-push hook reports failure because the existing formatter rewrites unrelated mcp-bridge files. Those unrelated changes were discarded; all typechecks and tests completed successfully.