Template compliance - #41
Merged
Merged
Conversation
Establish a green lint/format baseline so the new CI can enforce it: - add [tool.ruff] with per-file-ignores for the intentional post-setup imports (E402) in __init__.py, knowledge.py, and the guarded integration tests — the only E402s in src/tests, all deliberate. - fix 3 trivial test lints: two unused locals (F841) and an ambiguous `l` loop variable (E741). - apply black to the 8 drifted files under src/tests. use_cases/ (contributor scientific scripts) is intentionally left out of the lint/format gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Recreate the community/template files (superseding the stale, hastily-made
copilot/merge-template-repo-updates branch), updated to the current repo:
- .github/workflows/ci.yml — lint (ruff + black --check on src/tests) and a
non-integration pytest matrix on Python 3.12 & 3.13, all on uv. Complements
the existing docs.yml (mkdocs build + gh-deploy).
- .github/{CONTRIBUTING,SECURITY,CODE_OF_CONDUCT}.md — placed under .github/
(GitHub surfaces them from there; keeps root and the docs site clean).
CONTRIBUTING reflects the real uv workflow and `python -m pytest`; SECURITY
points at private vulnerability reporting; CODE_OF_CONDUCT is Contributor
Covenant 2.1.
- docs/developer.md — rewritten from a stub into a real dev guide (setup,
tests, lint/format, docs, codebase orientation).
- README — fix the broken developer-guide link (developer.md -> docs/developer.md).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ture - CLAUDE.md: add a "Prose register" house-style rule (plain/direct; no anthropomorphism, code-jockey slang, or advertising gloss; changelogs record behavior changes, not renames/doc churn) so the convention is written down rather than restated each time. Fix this file's own "Bundled assets (shipped …)" to "Built-in assets (declared …)". - docs/developer.md: lead codebase orientation with the Architecture page; frame CLAUDE.md accurately as the house-conventions / agent-instructions file rather than "the fullest map". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…his cycle Add a CLAUDE.md house rule: comments describe what the code does and why it exists now, never how it used to work or paradigms no longer in the tree (git holds the history). Rewrite three comments that narrated the change instead of the present: - memory.py: state the corrupt-file hazard, not "beats coercing to []". - provenance.py: state the null-session/ChromaDB hazard, not "(not a .get default)". - traces.py: describe the same-try ack placement's intent, not "if it raised outside". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tree-wide Remove the unreferenced SKILLS_COLLECTION and the TOOL_/SKILL_REGISTRY_COLLECTION back-compat aliases (migrate the one test that used TOOL_REGISTRY_COLLECTION to CODES_COLLECTION) — removing dead names beats commenting on why they linger. Rewrite comments/docstrings that narrated how the code used to be into present-tense statements of what it does and why, across registry, knowledge, session, info, setup_core_kb, mcp/server, and the codex/cline/base agents (e.g. "no longer forces telemetry" -> "sets no telemetry"; the server docstring no longer recounts the two-server merge; drop "the bge-base variant we used previously"). Also fixed a couple of "lives in" anthropomorphisms in passing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…pendency Embed per-subsystem PNG diagrams in the knowledge-base, memory, observability, provenance, and use-case pages. Add a section to memory.md comparing DSAgt memory with platform-native instruction files. Add ruyaml to dependencies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
torch is locked at 2.2.2 (the last release with x86_64 macOS wheels) and publishes no cp313 wheels, so the 3.13 test job fails at uv sync. Narrow requires-python to <3.13 and drop 3.13 from the CI matrix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CI resolves the floating ruff>=0.5.0 to 0.16.x, whose expanded default rule set reports 207 errors that 0.15.20 does not. Pin both linters to the versions the tree is clean under so CI and local runs agree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RAVarikoti
approved these changes
Aug 21, 2026
jychoi-hpc
self-requested a review
August 21, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository template compliance
Brings the repo in line with the organization template and cleans up prose and dead code found along the way.
CI and community files
.github/workflows/ci.yml: runsruff check src tests,black --check src tests, and the test suite..github/CONTRIBUTING.md,CODE_OF_CONDUCT.md,SECURITY.md.pyproject.toml:[tool.ruff]config withtarget-version = "py312"and per-file E402 ignores for the modules that must set env vars before heavy imports. Addsruyamlto dependencies.src/andtests/are now ruff- and black-clean.use_cases/is out of CI scope.Docs
CLAUDE.mdcodifies the prose register (plain, literal language; no change-narration in comments).docs/developer.mdrefreshed and pointed at the Architecture page; README link fixed.docs/assets/*.png).docs/memory.mdgains a section comparing DSAgt memory with platform-native instruction files.Code cleanup
registry.py: removes the unusedSKILLS_COLLECTIONand theTOOL_REGISTRY_COLLECTION/SKILL_REGISTRY_COLLECTIONaliases; no remaining readers.mcp/server.py,provenance.py,session.py,traces.py, agents, tests).No behavior changes beyond the dropped constants. Merged with
mainlocally, no conflicts.