Fix pyconfig strict validation for multimodal keys in text-only runs#4581
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NuojCheng
reviewed
Jul 23, 2026
NuojCheng
approved these changes
Jul 23, 2026
igorts-git
approved these changes
Jul 23, 2026
SurbhiJainUSC
marked this pull request as ready for review
July 23, 2026 21:31
SurbhiJainUSC
requested review from
A9isha,
RissyRan,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
July 23, 2026 21:31
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix pyconfig strict validation for multimodal keys in text-only runs
The Pydantic configuration validation in
pyconfig.pywas overly strict for text-only workflows (such as RL training). When processing model YAMLs that included multimodal parameters (likevision_encoder_blockorimage_size_for_vit), it would crash with a ValueError because those keys are not always in the active schema.This commit updates
_prepare_for_pydanticto check theuse_multimodalflag. Ifuse_multimodalis False, the parser now gracefully ignores these specific vision keys and drops them instead of crashing.FIXES: b/538001451
Tests
Local run
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.