Use the current NVDA TextRegion API - #53
Open
serrebidev wants to merge 2 commits into
Open
Conversation
Owner
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
braille.regions.base.TextRegionwhen available, falling back tobraille.TextRegionon older NVDA versions. This avoids the deprecated alias on current alpha builds while preserving compatibility with releases before the braille API split, as requested in review.The import lives in the existing compatibility module. Empty-list announcements use the selected class without changing their speech or braille behavior.
Validation:
CI limitation: the build workflow has existing repository-wide failures. Upstream master at
58d4a0creports 2,531 Pyright errors in the same local environment, including unresolved NVDA imports; the updated branch reports 2,536, with the new compatibility imports also subject to the missing NVDA environment. The previous CI run also found whitespace issues in the issue template, changelog, and pyproject. The missing trailing comma in the changed plug-in source is fixed here. Resolving the remaining template/type-check setup needs separate work; this PR does not disable those checks.Compatibility tests use simulated NVDA modules; interactive testing on older NVDA releases remains outstanding. The original PR reported a clean startup on NVDA alpha-57759 before this fallback revision.