Skip to content

fix terminal command completion, exit status, and PTY session recovery - #4

Open
3316891527 wants to merge 1 commit into
AAswordman:masterfrom
3316891527:fix/github-terminal-execution
Open

fix terminal command completion, exit status, and PTY session recovery#4
3316891527 wants to merge 1 commit into
AAswordman:masterfrom
3316891527:fix/github-terminal-execution

Conversation

@3316891527

Copy link
Copy Markdown

Summary

  • Add an explicit per-command completion marker so command execution does not depend solely on prompt parsing.
  • Propagate the shell exit code through CommandExecutionEvent.
  • Report dispatch failures and interactive-session misuse as completed failure events instead of leaving callers waiting.
  • Avoid treating canonical PTY FIONREAD=0 as proof that a command is waiting for input.
  • Serialize command events and fix the Process.exitValue() liveness contract.

Validation

  • git diff --check passed.
  • Android compilation was attempted with /root/android-sdk; the environment's aidl binary cannot start because the host lacks the required glibc loader.

This PR changes the terminal core only; it does not change the Linux rootfs or PRoot image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant