Port 2hire customizations to latest Metabase - #21
Draft
AGreenPlace wants to merge 10000 commits into
Draft
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The deployed
masterbranch was compared against the substantially newer Metabase code onmetabase-sync. Existing upstream implementations were retained where they supersede the old customization:skip_if_emptyalready removes individual empty cards, and Slack already chunks large outgoing block payloads. Reverted attachment batching, serialized debug logging, disabled pre-commit hooks, and removal of the shared EE build were intentionally not carried forward.Validation
bun run lint-format-pure— passed across 12,243 filesbun run lint-eslint-pure— passedbun run type-check— passed after rebuilding 491 ClojureScript modules with zero warnings./bin/test-agent :only '[metabase.channel.impl.slack-test]'— 11 tests and 26 assertions passed