Skip to content

Port 2hire customizations to latest Metabase - #21

Draft
AGreenPlace wants to merge 10000 commits into
masterfrom
metabase-sync
Draft

Port 2hire customizations to latest Metabase#21
AGreenPlace wants to merge 10000 commits into
masterfrom
metabase-sync

Conversation

@AGreenPlace

Copy link
Copy Markdown

Summary

  • restore the 2hire default logo in the current TypeScript component while preserving theme-aware coloring
  • split Slack dashboard filter fields into groups of at most 10 and keep the author/branding section last
  • publish the validated OSS artifact to the existing 2hire ECR repository with current pinned AWS and Docker actions
  • keep manually selected commit SHAs consistent when naming and retrieving uberjar artifacts

Context

The deployed master branch was compared against the substantially newer Metabase code on metabase-sync. Existing upstream implementations were retained where they supersede the old customization: skip_if_empty already removes individual empty cards, and Slack already chunks large outgoing block payloads. Reverted attachment batching, serialized debug logging, disabled pre-commit hooks, and removal of the shared EE build were intentionally not carried forward.

Validation

  • bun run lint-format-pure — passed across 12,243 files
  • bun run lint-eslint-pure — passed
  • bun run type-check — passed after rebuilding 491 ClojureScript modules with zero warnings
  • ./bin/test-agent :only '[metabase.channel.impl.slack-test]' — 11 tests and 26 assertions passed
  • focused Clojure lint — zero errors and warnings
  • workflow YAML lint and parsing — passed
  • repository pre-commit pipeline — passed

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.