Skip to content

Ci/windup add workflow#52

Open
xiaocheny214 wants to merge 2 commits into
1024XEngineer:mainfrom
xiaocheny214:ci/windup-add-workflow
Open

Ci/windup add workflow#52
xiaocheny214 wants to merge 2 commits into
1024XEngineer:mainfrom
xiaocheny214:ci/windup-add-workflow

Conversation

@xiaocheny214

Copy link
Copy Markdown

背景

配置 backend CI

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Found one correctness issue in the commit-message gate. The backend dependency sync, Ruff, import-linter, and pytest commands otherwise pass locally.

View job run

fi
echo "Base ref: $BASE_REF"
git fetch --no-tags origin "$BASE_REF"
BASE=$(git merge-base "origin/$BASE_REF" HEAD)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Validate the actual pushed commits on the default branch

For a push to the default branch, git fetch origin "$BASE_REF" updates origin/main to the same commit as HEAD, so this merge-base is HEAD and $BASE..HEAD is empty. Direct pushes to main therefore bypass the commit-message gate entirely. Use github.event.before (with an initial-push fallback) for push events, while retaining the merge-base calculation for pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant