fix(chainstore): key fee history cache by request parameters - #978
Merged
Conversation
Signed-off-by: zjuzhongwen <zjuzhongwen@outlook.com>
minhd-vu
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PassthroughStore.GetFeeHistorycurrently stores a single cachedeth_feeHistoryresult without recording the parameters that produced it.However, all three request parameters affect the response:
blockCountnewestBlockrewardPercentilesAs a result, a request made within the cache TTL can receive a result produced
for a different set of parameters.
For example:
If the first result is still cached, the second call returns that result without
sending another RPC request. The returned fee history therefore does not
correspond to the second request.
This change:
There are no breaking API changes.
Jira / Linear Tickets
Testing