What is wrong
The Checkstyle configuration suppresses the HideUtilityClassConstructorCheck check for a file named Target_BytecodeProviderInitiator, but no such file exists anywhere in the source tree. The class the suppression was written for was removed. The suppression now does nothing: it is dead configuration that a maintainer reading the file has to reason about for no benefit.
Where
- File:
src/checkstyle/checkstyle-suppressions.xml
- Advisory line: 81 (line numbers may drift; the entry sits under the
spring-orm comment)
- Occurrence, at line 81:
<suppress files="Target_BytecodeProviderInitiator" checks="HideUtilityClassConstructorCheck"/>
Evidence
config_kind: checkstyle_suppression
pattern: Target_BytecodeProviderInitiator
raw_line: <suppress files="Target_BytecodeProviderInitiator" checks="HideUtilityClassConstructorCheck"/>
matches_nothing_in_tree: true
names_a_literal: true
removed_in: commit 2350c8a8f5684fdb7f412df2ca8e7b3f67948a84, date 2024-04-30
score: 77 (config_kind_prior=40, names_a_literal=25, single_line_fix=10, staleness_years=2)
Suggested fix
Delete the single suppression line for Target_BytecodeProviderInitiator. The class it referenced was removed in commit 2350c8a8f5684fdb7f412df2ca8e7b3f67948a84 (2024-04-30), so the suppression can never apply again. Do not write the patch here.
How to verify the fix
From tools/candidate-miner/, run the config miner and confirm this fingerprint is no longer emitted:
./miner.py run --miner config_dead_entry --dry-run
Provenance
Mined at commit afa90816de83d8e9feed99b1c9e4c76adc088eb4 on branch main.
Generated by Candidate scan: file mined candidates as issues · opus48 · 78.8 AIC · ⌖ 29.8 AIC · ⊞ 4.6K · ◷
candidate-miner:fingerprint sha256:881deebf3ba28395bed46bea642fb141a9f1b7385baf81f119ce5e2df07e6b65
What is wrong
The Checkstyle configuration suppresses the
HideUtilityClassConstructorCheckcheck for a file namedTarget_BytecodeProviderInitiator, but no such file exists anywhere in the source tree. The class the suppression was written for was removed. The suppression now does nothing: it is dead configuration that a maintainer reading the file has to reason about for no benefit.Where
src/checkstyle/checkstyle-suppressions.xmlspring-ormcomment)Evidence
Suggested fix
Delete the single suppression line for
Target_BytecodeProviderInitiator. The class it referenced was removed in commit2350c8a8f5684fdb7f412df2ca8e7b3f67948a84(2024-04-30), so the suppression can never apply again. Do not write the patch here.How to verify the fix
From
tools/candidate-miner/, run the config miner and confirm this fingerprint is no longer emitted:Provenance
Mined at commit
afa90816de83d8e9feed99b1c9e4c76adc088eb4on branchmain.candidate-miner:fingerprint sha256:881deebf3ba28395bed46bea642fb141a9f1b7385baf81f119ce5e2df07e6b65