Skip to content

check this and update #7

Description

@satrianivzla

Hi there I am checking your code and it looks and works great!

Just a couple of minor issues

In your readme file you should add the info related to the user email account - looks like you forgot to add there - when you are creating a new user then must update to
$fullname = "Johnny Winter";
$login = "john"
$password = "123becarefulwithafool";
$email = "johnnywinter@hotmail.com";
$active = true;
$permissions = array(1, 3);
$new_user_id = $this->user_manager->save_user($fullname, $login, $password, $email, $active, $permissions);

Also I suggest to you add some kind of validation to the user_save method related that the email as the username should be unique.

And finally in the language file look like you forgot to add the line
$lang['error_inactive_account'] = "Your account is not active yet.";

I hope that soon you go to the Version 1.6, the remember me should be a great move and a must have!

Keep working hard on this!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions