Skip to content

Problem when doing comments for revision diffs #77

Description

@walty8

In a revision diff page, with a customised 'from' and 'to' revisions (as we normally batch review a range of changesets), I could still make comments there. However, there are two problems:

  1. the link in the comments page does not get me back to the diff page, instead, it bring me to the latest changeset regarding to the 'to' revision.

  2. the comments in the page have wrong positions.

It seems to be related with the following code in web.py

    def changeset_js_data(self, req, data):
        return {
            'page': 'changeset',
            'revision': data['new_rev'],
            'path': data['reponame'],
            'selectorToInsertAfter': 'div.diff div.diff:last'
        }

Apparently, only the reponame, and last revision is stored, instead of the actual diff. I wonder if it would be possible if the full browser URL is stored inside the 'path' column instead?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions