From d6419dfbd4af6f58c483c195456466f0687a89c1 Mon Sep 17 00:00:00 2001 From: Anton Shabanov Date: Wed, 16 Dec 2015 16:23:37 +0300 Subject: [PATCH 1/2] Log RenderedMessage along with exception in CaptureException --- src/app/SharpRaven.Log4Net/SentryAppender.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/app/SharpRaven.Log4Net/SentryAppender.cs b/src/app/SharpRaven.Log4Net/SentryAppender.cs index 231b5e6..b16f040 100644 --- a/src/app/SharpRaven.Log4Net/SentryAppender.cs +++ b/src/app/SharpRaven.Log4Net/SentryAppender.cs @@ -62,16 +62,15 @@ protected override void Append(LoggingEvent loggingEvent) var tags = tagLayouts.ToDictionary(t => t.Name, t => (t.Layout.Format(loggingEvent) ?? "").ToString()); var exception = loggingEvent.ExceptionObject ?? loggingEvent.MessageObject as Exception; + var message = loggingEvent.RenderedMessage; var level = Translate(loggingEvent.Level); if (exception != null) { - ravenClient.CaptureException(exception, null, level, tags: tags, extra: extra); + ravenClient.CaptureException(exception, message, level, tags: tags, extra: extra); } else { - var message = loggingEvent.RenderedMessage; - if (message != null) { ravenClient.CaptureMessage(message, level, tags, extra); From 79dd0e7934ca5dd239573759e56c83bbd7cef373 Mon Sep 17 00:00:00 2001 From: Anton Shabanov Date: Wed, 16 Dec 2015 16:24:23 +0300 Subject: [PATCH 2/2] Do not share RavenClient between appender instances as they would also share same Logger name --- src/app/SharpRaven.Log4Net/SentryAppender.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/SharpRaven.Log4Net/SentryAppender.cs b/src/app/SharpRaven.Log4Net/SentryAppender.cs index b16f040..0649839 100644 --- a/src/app/SharpRaven.Log4Net/SentryAppender.cs +++ b/src/app/SharpRaven.Log4Net/SentryAppender.cs @@ -20,7 +20,7 @@ public class SentryTag public class SentryAppender : AppenderSkeleton { - private static RavenClient ravenClient; + private RavenClient ravenClient; public string DSN { get; set; } public string Logger { get; set; } private readonly IList tagLayouts = new List();