Finding
While building the npm/PyPI publish workflows (eval#11), noticed ci.yml only runs lint+test for the Python side (src/, tests/). The TypeScript side (ts/) has real tests (tests/*.test.ts, run locally via npm test) and a typecheck script, but neither runs in CI on push/PR. A TS-breaking change to ts/src/ would merge to main without any automated signal.
Suggested fix
Add a ts job to .github/workflows/ci.yml, working-directory ts, running npm ci && npm run typecheck && npm test on push/PR to main — mirroring the existing Python lint+test jobs' triggers.
Context
Not blocking eval#11 (that PR only adds release-triggered publish workflows, which are a different concern from PR-triggered CI). Filing separately since it's a distinct, pre-existing gap, not something introduced by that PR.
Premium boundary: eval is public OSS; this is CI tooling only, no boundary concern.
Finding
While building the npm/PyPI publish workflows (eval#11), noticed
ci.ymlonly runs lint+test for the Python side (src/,tests/). The TypeScript side (ts/) has real tests (tests/*.test.ts, run locally vianpm test) and atypecheckscript, but neither runs in CI on push/PR. A TS-breaking change tots/src/would merge to main without any automated signal.Suggested fix
Add a
tsjob to.github/workflows/ci.yml, working-directoryts, runningnpm ci && npm run typecheck && npm teston push/PR to main — mirroring the existing Python lint+test jobs' triggers.Context
Not blocking eval#11 (that PR only adds release-triggered publish workflows, which are a different concern from PR-triggered CI). Filing separately since it's a distinct, pre-existing gap, not something introduced by that PR.
Premium boundary: eval is public OSS; this is CI tooling only, no boundary concern.